Skip to content
Success

Changes

Summary

  1. Disable bat AI, fixes #137 (commit: 7e1ff56) (details)
  2. First pass at removing NPCs from the playerlist (commit: 0d7eb8f) (details)
  3. Second pass: error fixing, more invisibility fixes (commit: 3869514) (details)
  4. Third pass: packet magic to pseudo-respawn NPCs (commit: 7eed360) (details)
  5. micro-efficiency, improvements (commit: 5690a7f) (details)
  6. Refactor (commit: 315bd72) (details)
  7. Handle all cases of the packet in NMS.java (commit: b77e8f9) (details)
Commit 7e1ff56e613479326b07871815f207333e6db679 by mcmonkey4eva
Disable bat AI, fixes #137

Bat AI wasn't overridden properly... now it is.
(commit: 7e1ff56)
The file was modifiedsrc/main/java/net/citizensnpcs/npc/entity/BatController.java (diff)
Commit 0d7eb8f2b3aa42be493a0027ac00265fdd0cfbc3 by mcmonkey4eva
First pass at removing NPCs from the playerlist

imperfect (causes pointless respawns) but a functional proof-of-concept.
(commit: 0d7eb8f)
The file was modifiedsrc/main/java/net/citizensnpcs/npc/entity/EntityHumanNPC.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/EventListen.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/npc/entity/HumanController.java (diff)
Commit 3869514a4a0d46611e800773ae7fdae966a06226 by mcmonkey4eva
Second pass: error fixing, more invisibility fixes

Handle teleporting, avoid cross-world errors.
(commit: 3869514)
The file was modifiedsrc/main/java/net/citizensnpcs/EventListen.java (diff)
Commit 7eed3601807cf5c44074a1b0c57d9cfa3cc6f55b by mcmonkey4eva
Third pass: packet magic to pseudo-respawn NPCs

also cache the NPC position to slightly improve efficiency. Micro-effic
matters a lot here.
(commit: 7eed360)
The file was modifiedsrc/main/java/net/citizensnpcs/EventListen.java (diff)
Commit 5690a7fb0777b30b26c409589f7d160e59a36c49 by mcmonkey4eva
micro-efficiency, improvements

Don't call .getBlock which is both slow and doesn't work in all cases.
Also don't compare worlds by name, compare by instance.
(commit: 5690a7f)
The file was modifiedsrc/main/java/net/citizensnpcs/EventListen.java (diff)
Commit 315bd72349c7f23cb0b0fc1e7a158637ef22fe97 by mcmonkey4eva
Refactor

Move the playerlsit packet handling to the NMS class
(commit: 315bd72)
The file was modifiedsrc/main/java/net/citizensnpcs/util/NMS.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/EventListen.java (diff)
Commit b77e8f940a101aa4b4e0e3c7c328e3652456b15f by mcmonkey4eva
Handle all cases of the packet in NMS.java
(commit: b77e8f9)
The file was modifiedsrc/main/java/net/citizensnpcs/util/NMS.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/EventListen.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/npc/entity/HumanController.java (diff)