Skip to content
Success

Changes

Summary

  1. Fixes (commit: 3cc63ff) (details)
  2. Set pathing delay to be same as Minecraft's (commit: 03ef04a) (details)
  3. Update EventListen.java (commit: 0ca55e5) (details)
  4. Fix player NPCs not working with /npc name (commit: 767dfe1) (details)
  5. improve player NPC skins (commit: 6d31467) (details)
  6. Fix NPC's are not visible sometimes (commit: 2b3f91e) (details)
The file was modifiedsrc/main/java/net/citizensnpcs/npc/CitizensNPC.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/npc/ai/MCTargetStrategy.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/npc/entity/HumanController.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/commands/TraitCommands.java (diff)
Commit 03ef04a04a5449ca2cbda0a5aa5b12ee8ded61d7 by fullwall
Set pathing delay to be same as Minecraft's
(commit: 03ef04a)
The file was modifiedsrc/main/java/net/citizensnpcs/npc/ai/MCTargetStrategy.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/EventListen.java (diff)
Commit 767dfe142badb92f4505eb5c3ce55545ed9ff78d by fullwall
Fix player NPCs not working with /npc name
(commit: 767dfe1)
The file was modifiedsrc/main/java/net/citizensnpcs/npc/CitizensNPC.java (diff)
Commit 6d31467be6311e9aed376dac37fdf691370020f2 by jcthepants
improve player NPC skins
add skin packages with skin classes
add profile package with profile fetcher classes
update commands
update EventListen
update NMS
fix radius squared
fix exception message
fix npc sometimes not removed from playerlist
fix cannot add npc to playerlist
code/comment cleanup and refactoring
remove unused skin settings
removed NPC_SKIN_RETRY_DELAY, MAX_NPC_SKIN_RETRIES
current code uses cached textures if a skin profile request fails.
add setting for updating skin
added NPC_SKIN_UPDATE: true to always get the latest skin, false to use
cached skin if available, default is false.
minor code fixes, refactoring, add settings
removed assert
removed thread checks
added setting: NPC_SKIN_VIEW_DISTANCE
added setting: NPC_SKIN_UPDATE_DISTANCE
added setting: MAX_PACKET_ENTRIES
invoke EventListen#SkinUpdateTracker#reset from within #shouldUpdate
instead of requiring it to be invoked manually.
fix cached locations not used in EventListen#getNearbySkinnableNPCs
clamp yaw in EventListen.SkinUpdateTracker
use static constants
rename EntitySkinnable to SkinnableEntity
add SkinnableEntity interface to PlayerNPC (CraftPlayer)
remove unused code from PlayerListRemover
replace Subscriber with direct notification to entity via method
Undo EntityController interface changes
moved skin code from HumanController to CitizensNPC
fix npcs sometimes do not show
... due to packet tracker not being notified that remove packets have
been cancelled
fix imports rearranged by incorrect IDE settings
(commit: 6d31467)
The file was addedsrc/main/java/net/citizensnpcs/npc/profile/ProfileFetchThread.java
The file was addedsrc/main/java/net/citizensnpcs/npc/skin/PlayerListRemover.java
The file was modifiedsrc/main/java/net/citizensnpcs/npc/AbstractEntityController.java (diff)
The file was addedsrc/main/java/net/citizensnpcs/npc/skin/Skin.java
The file was addedsrc/main/java/net/citizensnpcs/npc/skin/SkinPacketTracker.java
The file was modifiedsrc/main/java/net/citizensnpcs/npc/CitizensNPC.java (diff)
The file was addedsrc/main/java/net/citizensnpcs/npc/profile/ProfileFetchSubscriber.java
The file was addedsrc/main/java/net/citizensnpcs/npc/profile/ProfileFetchResult.java
The file was modifiedsrc/main/java/net/citizensnpcs/commands/NPCCommands.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/npc/entity/HumanController.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/npc/entity/EntityHumanNPC.java (diff)
The file was addedsrc/main/java/net/citizensnpcs/npc/skin/SkinnableEntity.java
The file was addedsrc/main/java/net/citizensnpcs/npc/profile/ProfileFetcher.java
The file was modifiedsrc/main/java/net/citizensnpcs/EventListen.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/util/nms/PlayerlistTrackerEntry.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/util/NMS.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/Settings.java (diff)
The file was addedsrc/main/java/net/citizensnpcs/npc/profile/ProfileRequest.java
Commit 2b3f91e08a3c92bdee0014890fa5ccfd26df8269 by jcthepants
Fix NPC's are not visible sometimes
...Fixed invisible NPC's by allowing new update tasks to cancel current
tasks instead of cancelling the new task in
SkinPacketTracker#updateViewer
cancel packets in SkinPacketTracker#updateViewer after getting
PlayerEntry to ensure current scheduled tasks are cancelled.
remove LinkedList, replace with ArrayDeque
ensure EventListen#recalculatePlayer does not execute for NPC's
do a little less work in EventListen.SkinUpdateTracker#shouldUpdate
don't add skinnable entity to pending map if using cache skin -
Skin#apply
remove redundant fetch per NPC in Skin; Skin can already fetch once for
itself
fix and improve thread safety for profile fetcher; prevent external
access to threads Runnable interface; honor subscriber always invoked
from main thread.
rename ProfileFetchSubscriber to ProfileFetchHandler since subscriber
implies the handler will be used continuously
(commit: 2b3f91e)
The file was modifiedsrc/main/java/net/citizensnpcs/npc/skin/PlayerListRemover.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/npc/profile/ProfileRequest.java (diff)
The file was removedsrc/main/java/net/citizensnpcs/npc/profile/ProfileFetchSubscriber.java
The file was modifiedsrc/main/java/net/citizensnpcs/EventListen.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/npc/profile/ProfileFetchThread.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/npc/skin/Skin.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/npc/profile/ProfileFetcher.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/npc/CitizensNPC.java (diff)
The file was addedsrc/main/java/net/citizensnpcs/npc/profile/ProfileFetchHandler.java
The file was modifiedsrc/main/java/net/citizensnpcs/npc/skin/SkinPacketTracker.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/util/NMS.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/npc/entity/HumanController.java (diff)
The file was modifiedsrc/main/java/net/citizensnpcs/commands/NPCCommands.java (diff)